fix: creating change requests in private cloud UI #2953
Merged
+6
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team,
kyle-ssg and
khvn26
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
front-end
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2953 +/- ##
=======================================
Coverage 95.64% 95.64%
=======================================
Files 1012 1012
Lines 29182 29181 -1
=======================================
Hits 27911 27911
+ Misses 1271 1270 -1
☔ View full report in Codecov by Sentry. |
dabeeeenster
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR came from a bug identified when trying to create change requests / scheduled changes when using the UI directly in the flagsmith-private-cloud image.
Investigation into showed that it was using a template that hadn't been updated and that there were in fact 3 different index files (1 handlebars and 2 index.html).
I've consolidated this to 2 (since handlebars doesn't work in all situations) and improved the webpack processes (removed a lot of the unnecessary bash statements to rely on webpack only).
How did you test this code?
Built the image locally with the workflows logic also included and verified that I can create a change request / schedule a change to a feature.