-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle payment errors during user flow #2951
Merged
matthewelwell
merged 5 commits into
main
from
fix/handle_payment_errors_during_user_flow
Nov 13, 2023
Merged
fix: Handle payment errors during user flow #2951
matthewelwell
merged 5 commits into
main
from
fix/handle_payment_errors_during_user_flow
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
zachaysan
commented
Nov 10, 2023
matthewelwell
approved these changes
Nov 13, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2951 +/- ##
==========================================
+ Coverage 95.64% 95.65% +0.01%
==========================================
Files 1012 1012
Lines 29173 29207 +34
==========================================
+ Hits 27902 27938 +36
+ Misses 1271 1269 -2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingChanges
Ticket reference
Before this PR we were treating all errors from the chargebee client as one thing and we responded to a user that was in the process of signing up by issuing a 500 error, we were also logging all the chargebee errors as exceptions even though a declined credit card shouldn't be. Now, if the error is payment related, a
400
error gets sent to the client with a message to contact their administrator.How did you test this code?
A combination of manual probing through the code with the test suite on and two new tests.
Remaining TODOs
[ ] Team up with @novakzaballa and get the frontend hooked up so the change will actually matter.