Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rebuild environments when stop serving flags changed #2944

Merged

Conversation

zachaysan
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add a conditional after save hook to rebuild the documents if the stop serving flags bool is changed.

How did you test this code?

With a debugger first to make sure the task call was going through, and later with two new tests that mocked it.

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 7:26pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 7:26pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Nov 8, 2023 7:26pm

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Uffizzi Preview deployment-40348 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0eefdd) 95.64% compared to head (6a05f92) 95.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2944   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files        1012     1012           
  Lines       29154    29173   +19     
=======================================
+ Hits        27883    27902   +19     
  Misses       1271     1271           
Files Coverage Δ
api/organisations/models.py 93.86% <100.00%> (+0.23%) ⬆️
api/organisations/tests/test_models.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaysan zachaysan added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 7d16197 Nov 9, 2023
@zachaysan zachaysan deleted the fix/rebuild_environments_when_stop_serving_flags_changed branch November 9, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants