feat: Add permission for manage segments overrides #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2919 +/- ##
==========================================
+ Coverage 95.54% 95.56% +0.01%
==========================================
Files 1012 1013 +1
Lines 29329 29419 +90
==========================================
+ Hits 28023 28114 +91
+ Misses 1306 1305 -1
☔ View full report in Codecov by Sentry. |
api/environments/permissions/migrations/0008_add_manage_segment_overrides_permission.py
Show resolved
Hide resolved
…nage_segments_overrides
matthewelwell
approved these changes
Nov 13, 2023
zachaysan
changed the title
zachaysan
changed the title
…nage_segments_overrides
zachaysan
changed the title
zachaysan
deleted the
feat/add_permission_for_manage_segments_overrides
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Segment overrides allows release of a specific feature to broader set of users, with this change Flagsmith users are able to have a specialized permission for managing segment overrides as an environment role. See this for more information.
Most of the work in this PR involved trying to understand the surrounding approach and replace permission checks as needed.
I also added
django_extensionsfor local development ergonomics as well.How did you test this code?
I relied on the existing tests, following the convention of relying on
admin_master_api_key_client, but this means that we're not really testing the new permission since it's an admin api key, not a user with the permission.I would like to test this locally with the interface to verify that the permission checks work properly, but I'm opening the PR first to get feedback before setting that all up.I have fully tested this code through a locally running webserver and caught and debugged a few small issues. This PR must wait for merge until the frontend is ready.