-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(task/priority): change field to SmallIntegerField #2914
Conversation
Change field type to avoid check constraint Sqlmigrate: ``` BEGIN; │ -- │ -- Add field priority to task │ -- │ ALTER TABLE "task_processor_task" ADD COLUMN "priority" smallint NULL; │ COMMIT; ```
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2914 +/- ##
=======================================
Coverage 95.63% 95.63%
=======================================
Files 1011 1011
Lines 29006 29006
=======================================
Hits 27741 27741
Misses 1265 1265
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to manually change this in staging I guess.
Yeah, just drop the check constraint |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingChanges
Change field type to avoid check constraint
Sqlmigrate
How did you test this code?
Covered by unit tests