Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: partial imports, off values as control value #2864

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 19, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Closes #2838.

  • Remove transaction from the import task
  • Create control values for mulrivariate features from LD's off values
  • Generic error logging

How did you test this code?

Modified relevant unit tests.

- Remove transaction from the import task
- Create control values for mulrivariate features from LD's off values
- Generic error logging
@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 3:44pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 3:44pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 3:44pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Uffizzi Preview deployment-38935 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b0ef013) 95.60% compared to head (6ad60ff) 95.61%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2864   +/-   ##
=======================================
  Coverage   95.60%   95.61%           
=======================================
  Files        1009     1009           
  Lines       28904    28910    +6     
=======================================
+ Hits        27634    27641    +7     
+ Misses       1270     1269    -1     
Files Coverage Δ
api/integrations/launch_darkly/services.py 100.00% <100.00%> (ø)
...s/unit/integrations/launch_darkly/test_services.py 100.00% <100.00%> (ø)
api/integrations/launch_darkly/tasks.py 71.42% <0.00%> (+4.76%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit 93df958 Oct 23, 2023
@khvn26 khvn26 deleted the feat/partial-imports branch October 23, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API docs Documentation updates front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow partial LaunchDarkly imports
3 participants