feat(rate-limit/redis): Use redis to store throttling data for admin endpoints #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2863 +/- ##
==========================================
- Coverage 95.99% 95.64% -0.36%
==========================================
Files 1068 1013 -55
Lines 32721 29033 -3688
==========================================
- Hits 31411 27769 -3642
+ Misses 1310 1264 -46 ☔ View full report in Codecov by Sentry. |
gagantrivedi
changed the title
gagantrivedi
changed the title
use redis for user throttle cache implement admin rate throttle Add default value for redis cache env Add redis cache url misc throttle fixes [minor] refac: remove explicit redis cache review fixes fix tests change scope refac: use explicit throttle_class Add helpful comments to settings rollback sentry sampler changes [minor] fix test settings improve settings wip: tests [minor] don't throttle selfhosted telemetry view update lock file refactor tests
gagantrivedi
force-pushed
the
feat/redis
branch
from
adc0927 to
5f50a29
Compare
matthewelwell
approved these changes
Jan 29, 2024
|
Will be merged after the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Add support for using redis to store throttling data
How did you test this code?
Adds unit tests