Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE changes to add/remove User/Groups to/from Roles #2754

Closed
novakzaballa opened this issue Sep 7, 2023 · 10 comments · Fixed by #2791
Closed

FE changes to add/remove User/Groups to/from Roles #2754

novakzaballa opened this issue Sep 7, 2023 · 10 comments · Fixed by #2791
Assignees
Labels
front-end Issue related to the React Front End Dashboard improvement Improvement to the existing platform

Comments

@novakzaballa
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, the API supports adding users and groups to roles however in the frontend we don't have a way to do it.

Describe the solution you'd like

In the management option of the top bar, when the admin goes to the members tab, we should display a roles sub-tab,
When an admin edits a role, a modal is shown, and in the first tab, where the name and description of the role are shown, we need to allow the admin to add and remove users and/or groups to the role.

Additional context
Initially, the ability to add and remove users/groups will reside only on the roles sub-tab of the members tab, in the screen shown when an admin clicks on the Management top menu option

@novakzaballa
Copy link
Contributor Author

Image

Image

Image

Image

@kyle-ssg @matthewelwell

@matthewelwell
Copy link
Contributor

I think this is fine for now, but might get a bit cluttered for larger teams. We may need to rethink it at that point but, for the initial release, I think this is fine.

@matthewelwell
Copy link
Contributor

We'll also need to implement the functionality from the other side - adding roles directly to a user or a group.

@novakzaballa
Copy link
Contributor Author

Image

Image

@novakzaballa
Copy link
Contributor Author

The above designs show how we would add roles to users and groups

@matthewelwell
Copy link
Contributor

@novakzaballa @dabeeeenster I think this might need a bit more thought from a design perspective. Can you guys organise?

@novakzaballa
Copy link
Contributor Author

@dabeeeenster new designs show how we would add users to roles and manage roles in project and environment

Image
Image
Image
Image

@dabeeeenster
Copy link
Contributor

@novakzaballa are these pushed to the PR? Can you link this issue to the PR too?

@novakzaballa novakzaballa linked a pull request Sep 20, 2023 that will close this issue
4 tasks
@novakzaballa
Copy link
Contributor Author

@dabeeeenster this is the PR: #2791

@dabeeeenster dabeeeenster added improvement Improvement to the existing platform front-end Issue related to the React Front End Dashboard labels Oct 5, 2023
@kyle-ssg kyle-ssg reopened this Jan 25, 2024
@kyle-ssg
Copy link
Member

This issue was closed but I believe the "show_role_management" feature should be enabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard improvement Improvement to the existing platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants