-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(migrations): remove features/0060 set environment not null #2738
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2738 +/- ##
==========================================
- Coverage 95.48% 95.47% -0.01%
==========================================
Files 994 993 -1
Lines 27939 27909 -30
==========================================
- Hits 26677 26647 -30
Misses 1262 1262
☔ View full report in Codecov by Sentry. |
So, I guess there are some considerations here:
Since the migration hasn't materially changed the behaviour of the code we can probably get away with doing neither of these, but it might be slightly confusing to see. I would recommend that we do do both. |
Yeah, both would be ideal |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingChanges
Revert 55a9ef7
How did you test this code?
N/A