Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UI issue when there were more than 100 features #2711

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix: UI issue when there were more than 100 features #2711

merged 1 commit into from
Sep 6, 2023

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Install and use react-virtualized inside react-window

How did you test this code?

  • Go to Features page.
  • Create more than 100 features.
  • Click any feature.
  • Go to "Segment Overrides" tab.
  • Click "Update Segment override".
  • The error no longer occurs and works correctly.

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Aug 30, 2023
@novakzaballa novakzaballa linked an issue Aug 30, 2023 that may be closed by this pull request
Updating segment overrides in a project with > 100 features causes UI issue #2668
Closed
4 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023 •
edited
Loading

Uffizzi Preview deployment-34831 was deleted.

@vercel
Copy link

vercel bot commented Aug 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:33pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:33pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 7:33pm

@novakzaballa novakzaballa requested review from a team, gagantrivedi and matthewelwell August 30, 2023 19:30
matthewelwell
matthewelwell approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'm not sure on the consequences / which places to test to ensure there aren't any regressions.

@matthewelwell
Copy link
Contributor

I've tested this against segments and the audit log and everything seems ok to me.

@matthewelwell matthewelwell merged commit c1a62ce into main Sep 6, 2023
@matthewelwell matthewelwell deleted the fix/more-than-200-features-causes-ui-issue branch September 6, 2023 15:13
@dabeeeenster dabeeeenster mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@gagantrivedi gagantrivedi Awaiting requested review from gagantrivedi gagantrivedi was automatically assigned from Flagsmith/flagsmith

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating segment overrides in a project with > 100 features causes UI issue
2 participants
@novakzaballa @matthewelwell