Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Home page announcement #2710

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented Aug 30, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Show an announcement at the top of the home page.
The title, body and link of the annouoncement are provided in the value attribute of the announcement feature flag on our production environment of the Flagsmith Website project.
Example value:

{ 
"id":"announcement-1",
"title":"Master Feature Flags & Progressive Delivery!",
"description":"Join us in London for a hands-on workshop with Dynatrace on feature flags and observability-driven progressive delivery.",
"buttonText":"Save My Seat!",
"url":"https://info.dynatrace.com/emea-uk-dh-progressive-delivery-workshop-flagsmith-22371-registration.html",
"isClosable":true
}

How did you test this code?

This code has been manually tested by setting a JSON value for the announcement feature flag, and verifying that:

  • The banner is shown with the correct content
  • The button has the right label and when clicked opens a new tab with the right URL
  • When dismissed is not being shown anymore to the same user

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Aug 30, 2023
@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 6:02pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 6:02pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 6:02pm

@novakzaballa novakzaballa changed the title Feat: Home page announcement feat: Home page announcement Aug 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Uffizzi Preview deployment-34818 was deleted.

@matthewelwell matthewelwell merged commit 9de235b into main Aug 31, 2023
@matthewelwell matthewelwell deleted the feat/announcement-in-the-top branch August 31, 2023 08:23
This was referenced Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants