Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user-create): duplicate email error message #2642

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Aug 14, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Return a generic error message for user create if the email is not unique

How did you test this code?

covered by unit test cases and verified manually by creating a user with duplicate email

Return generic error message
@vercel
Copy link

vercel bot commented Aug 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 3:03pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 3:03pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 3:03pm

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

Uffizzi Preview deployment-33508 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (1514bf7) 95.44% compared to head (ecfb3eb) 95.43%.
Report is 16 commits behind head on main.

❗ Current head ecfb3eb differs from pull request most recent head f34b363. Consider uploading reports for the commit f34b363 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2642      +/-   ##
==========================================
- Coverage   95.44%   95.43%   -0.01%     
==========================================
  Files         976      975       -1     
  Lines       27319    27253      -66     
==========================================
- Hits        26074    26010      -64     
+ Misses       1245     1243       -2     
Files Changed Coverage Δ
api/audit/serializers.py 100.00% <100.00%> (ø)
api/custom_auth/serializers.py 100.00% <100.00%> (ø)
api/custom_auth/tests/test_serializer.py 100.00% <100.00%> (ø)
api/environments/serializers.py 95.52% <100.00%> (-0.32%) ⬇️
api/environments/views.py 90.59% <100.00%> (+1.16%) ⬆️
api/organisations/views.py 91.16% <100.00%> (ø)
api/projects/serializers.py 100.00% <100.00%> (ø)
api/projects/tests/test_serializers.py 100.00% <100.00%> (ø)
api/projects/views.py 94.01% <100.00%> (-0.30%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi requested review from a team, khvn26 and matthewelwell August 14, 2023 08:53
@gagantrivedi gagantrivedi merged commit 7b65a8d into main Aug 16, 2023
@gagantrivedi gagantrivedi deleted the fix/signup/email-msg branch August 16, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants