Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metadata validation causes AttributeError for patch requests #2614

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes AttributeError raised by metadata validation logic when using patch request on environments viewset.

How did you test this code?

Added a new unit test to verify that the issue is resolved.

@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 4:47pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 4:47pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 4:47pm

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Uffizzi Preview deployment-33050 was deleted.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 94.11% and no project coverage change.

Comparison is base (cb42f9d) 95.43% compared to head (bd11011) 95.43%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2614   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files         975      975           
  Lines       27245    27252    +7     
=======================================
+ Hits        26002    26009    +7     
  Misses       1243     1243           
Files Changed Coverage Δ
api/environments/serializers.py 95.52% <85.71%> (-1.41%) ⬇️
api/environments/tests/test_views.py 100.00% <100.00%> (ø)
api/metadata/serializers.py 91.89% <100.00%> (+1.35%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell merged commit 5e13707 into main Aug 10, 2023
@matthewelwell matthewelwell deleted the fix/partial-environment-update branch August 10, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants