Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add descriptive event title to dynatrace integration #2424

Merged
merged 7 commits into from
Jul 18, 2023
Merged

feat: add descriptive event title to dynatrace integration #2424

merged 7 commits into from
Jul 18, 2023

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Jul 12, 2023 •
edited
Loading

Changes

Adds the deployment title element to Dynatrace events. See #2414 for more details.

How did you test this code?

Updated existing unit tests.

@matthewelwell matthewelwell linked an issue Jul 12, 2023 that may be closed by this pull request
Add descriptive event title to Dynatrace Integration #2414
Open
@vercel
Copy link

vercel bot commented Jul 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 4:20pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 4:20pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 4:20pm

@github-actions github-actions bot added the api Issue related to the REST API label Jul 12, 2023
@matthewelwell matthewelwell mentioned this pull request Jul 12, 2023
Open
@dabeeeenster dabeeeenster changed the title Feature/2414/add descriptive event title to dynatrace integration feat: dd descriptive event title to dynatrace integration Jul 13, 2023
@matthewelwell matthewelwell changed the title feat: dd descriptive event title to dynatrace integration feat: add descriptive event title to dynatrace integration Jul 17, 2023
@matthewelwell matthewelwell force-pushed the feature/2414/add-descriptive-event-title-to-dynatrace-integration branch from 5a5f60a to d1383d7 Compare July 17, 2023 14:56
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited
Loading

Uffizzi Preview deployment-31089 was deleted.

@matthewelwell matthewelwell force-pushed the feature/2414/add-descriptive-event-title-to-dynatrace-integration branch from 5340fa0 to 5dda725 Compare July 17, 2023 15:49
@matthewelwell matthewelwell requested review from a team and gagantrivedi July 17, 2023 16:12
matthewelwell
matthewelwell commented Jul 17, 2023
View reviewed changes
api/integrations/common/wrapper.py
Comment on lines +21 to +22
@staticmethod
@abstractmethod
Copy link
Contributor Author

@matthewelwell matthewelwell Jul 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just resolving a deprecation warning that is unrelated to this PR.

@matthewelwell matthewelwell marked this pull request as ready for review July 17, 2023 16:27
@matthewelwell matthewelwell merged commit f1dba53 into main Jul 18, 2023
@matthewelwell matthewelwell deleted the feature/2414/add-descriptive-event-title-to-dynatrace-integration branch July 18, 2023 08:54
@dabeeeenster dabeeeenster mentioned this pull request Jul 18, 2023
Merged
@dabeeeenster dabeeeenster mentioned this pull request Aug 22, 2023
Closed
@dabeeeenster dabeeeenster mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagantrivedi gagantrivedi gagantrivedi approved these changes

Assignees
No one assigned
Labels
api Issue related to the REST API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add descriptive event title to Dynatrace Integration
2 participants
@matthewelwell @gagantrivedi