Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Manage segment overrides" environment permission #1676

Closed
4 tasks
luk355 opened this issue Nov 21, 2022 · 3 comments · Fixed by #2936
Closed
4 tasks

Add "Manage segment overrides" environment permission #1676

luk355 opened this issue Nov 21, 2022 · 3 comments · Fixed by #2936
Assignees
Labels
api Issue related to the REST API feature New feature or request front-end Issue related to the React Front End Dashboard
Milestone

Comments

@luk355
Copy link
Contributor

luk355 commented Nov 21, 2022

Segment overrides allows release of a specific feature to broader set of users. Not all Flagsmith users should have access to update this settings, therefore, I would be great to have dedicated "Manage segment overrides" environment role which would limit this.

This feature would also work well with the 4 eyes as segment overrides are not hidden behind the feature flag.

Acceptance Criteria

  • Users and groups can be given a new 'Manage Segment Overrides' permission
  • Non-Admin users with the 'Manage Segment Overrides' permission in a given environment are able to add, edit and remove segment overrides for flags in that environment
  • Non-Admin users without the 'Manage Segment Overrides' in a given environment are able to view segment overrides for flags in that environment
  • Non-Admin users without the 'Manage Segment Overrides' in a given environment are not able to add, edit or remove segment overrides for flags in that environment
@dabeeeenster dabeeeenster added feature New feature or request front-end Issue related to the React Front End Dashboard api Issue related to the REST API labels Nov 21, 2022
@dabeeeenster dabeeeenster added this to the Larger Teams milestone Nov 21, 2022
@dabeeeenster
Copy link
Contributor

This sounds sensible to me - thoughts @gagantrivedi @kyle-ssg @matthewelwell ?

@matthewelwell
Copy link
Contributor

Yes, for sure.

@zachaysan
Copy link
Contributor

The backend work for this feature is nearly complete. During testing I determined that we are going to need some frontend rule changes to make the interface work as expected for our customers.

Image

Right now the segment overrides section of the interface is still active looking if a user has the ability to edit features. Since this is a different permission, however, we'll now need to check if the user has the MANAGE_SEGMENT_OVERRIDES permission and only show a read-only version of the interface if they do not have it.

In addition to the above, please also hide the Create Feature-Specific Segment button if the user is missing the project permission MANAGE_SEGMENTS since they will not be able to create a segment if that permission is missing.

Image

@novakzaballa novakzaballa linked a pull request Nov 7, 2023 that will close this issue
4 tasks
@novakzaballa novakzaballa changed the title Add "Manage segment overrides" environment role Add "Manage segment overrides" environment permission Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants