Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use OAuth login with invite links if ALLOW_REGISTRATION_WITHOUT_INVITE=false #1563

Closed
matthewelwell opened this issue Oct 21, 2022 · 3 comments · Fixed by #2731
Closed
Labels
api Issue related to the REST API bug Something isn't working

Comments

@matthewelwell
Copy link
Contributor

The issue is here: https://github.com/Flagsmith/flagsmith/blob/main/api/custom_auth/serializers.py#L54

If ALLOW_REGISTRATION_WITHOUT_INVITE is disabled, we check to see if there is a valid invite, however, this only works for email invites. We need a way to determine if the user landed on the page from an invite link.

@matthewelwell matthewelwell added bug Something isn't working api Issue related to the REST API labels Oct 21, 2022
@mvrhov
Copy link

mvrhov commented Aug 31, 2023

It's not just OAuth is normal sign-up too

@matthewelwell
Copy link
Contributor Author

It's not just OAuth is normal sign-up too

Sorry, I don't quite follow. Can you elaborate on the issue you're facing please? Please provide screenshots too.

@mvrhov
Copy link

mvrhov commented Aug 31, 2023

I have set the ALLOW_REGISTRATION_WITHOUT_INVITE to false and copy pasted the invite link to a few persons so they could create accounts. They get an error stating that they cannot create account without invite link. They got to signup form from invite link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API bug Something isn't working
Projects
None yet
2 participants