Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics integrations not honouring MV flags for Identities calls #143

Closed
dabeeeenster opened this issue Jun 21, 2021 · 2 comments
Closed

Analytics integrations not honouring MV flags for Identities calls #143

dabeeeenster opened this issue Jun 21, 2021 · 2 comments
Assignees
@dabeeeenster @matthewelwell
Labels
api Issue related to the REST API bug Something isn't working

Comments

@dabeeeenster
Copy link
Contributor

Analytics integration code needs updating to honour Identity MV flag value as opposed to control value.
@dabeeeenster dabeeeenster added bug Something isn't working api Issue related to the REST API labels Jun 21, 2021
@dabeeeenster
Copy link
Contributor Author

Code needs updating at

flagsmith/api/integrations/segment/segment.py

Line 17 in 8e8d527

def generate_user_data(self, user_id, feature_states):
and potentially other integrations

@dabeeeenster
Copy link
Contributor Author

Fixed with #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dabeeeenster dabeeeenster

@matthewelwell matthewelwell

Labels
api Issue related to the REST API bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dabeeeenster @matthewelwell