fix(trait/create): use update_or_create to avoid race condition (#371)

Author: gagantrivedi

api/environments/identities/models.py

@@ -159,7 +159,6 @@ def update_traits(self, trait_data_items):
         """
         current_traits = self.get_all_user_traits()
 
-        new_traits = []
         keys_to_delete = []
 
         for trait_data_item in trait_data_items:
@@ -180,12 +179,9 @@ def update_traits(self, trait_data_items):
                     setattr(current_trait, attr, value)
                 current_trait.save()
             else:
-                # create a new trait and append it to the list of new traits
-                new_traits.append(
-                    Trait.objects.create(
-                        trait_key=trait_key, identity=self, **trait_value_data
-                    )
-                )
+                # use update_or_create to avoid race condition
+                kwargs = {"trait_key": trait_key, "identity": self}
+                Trait.objects.update_or_create(defaults=trait_value_data, **kwargs)
 
         # delete the traits that had their keys set to None
         if keys_to_delete: