diff --git a/frontend/web/components/Feature.js b/frontend/web/components/Feature.js index ee2fa19393a8..95b148a18e73 100644 --- a/frontend/web/components/Feature.js +++ b/frontend/web/components/Feature.js @@ -44,11 +44,11 @@ export default class Feature extends PureComponent { const enabledString = isEdit ? 'Enabled' : 'Enabled by default' const disabled = hide_from_client - const controlValue = Utils.calculateControl(multivariate_options) + const controlPercentage = Utils.calculateControl(multivariate_options) const valueString = identity ? 'User override' : !!multivariate_options && multivariate_options.length - ? `Control Value - ${controlValue}%` + ? `Control Value - ${controlPercentage}%` : `Value (optional)${' - these can be set per environment'}` const showValue = !( @@ -103,7 +103,8 @@ export default class Feature extends PureComponent { {}} @@ -121,7 +122,8 @@ export default class Feature extends PureComponent { {(!!environmentVariations || !isEdit) && ( + } > - Set the Feature state to On or Off for Identities in this Segment + Set the Feature state to On or Off for Identities in this + Segment { const foundMv = diff --git a/frontend/web/components/mv/VariationOptions.js b/frontend/web/components/mv/VariationOptions.js index 60b6e555a388..309e661a0125 100644 --- a/frontend/web/components/mv/VariationOptions.js +++ b/frontend/web/components/mv/VariationOptions.js @@ -5,6 +5,7 @@ import InfoMessage from 'components/InfoMessage' import ErrorMessage from 'components/ErrorMessage' export default function VariationOptions({ + controlPercentage, controlValue, disabled, multivariateOptions, @@ -18,7 +19,7 @@ export default function VariationOptions({ variationOverrides, weightTitle, }) { - const invalid = multivariateOptions.length && controlValue < 0 + const invalid = multivariateOptions.length && controlPercentage < 0 if (!multivariateOptions || !multivariateOptions.length) { return null } @@ -28,7 +29,10 @@ export default function VariationOptions({ return ( <> {invalid && ( - + )} {!preventRemove && (