From eab1f6db74a9b0ba728e081bcc6ce83001553b15 Mon Sep 17 00:00:00 2001 From: Gagan Trivedi Date: Wed, 20 Dec 2023 18:13:24 +0530 Subject: [PATCH] fix(admin/task-processor): handle no task run (#3196) --- api/task_processor/admin.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/api/task_processor/admin.py b/api/task_processor/admin.py index 8cea083ad31f..6a32fc765cf6 100644 --- a/api/task_processor/admin.py +++ b/api/task_processor/admin.py @@ -1,3 +1,5 @@ +from typing import Optional + from django.contrib import admin from task_processor.models import RecurringTask @@ -14,5 +16,7 @@ class RecurringTaskAdmin(admin.ModelAdmin): ) readonly_fields = ("args", "kwargs") - def last_run_status(self, instance: RecurringTask) -> str: - return instance.task_runs.order_by("-started_at").first().result + def last_run_status(self, instance: RecurringTask) -> Optional[str]: + if last_run := instance.task_runs.order_by("-started_at").first(): + return last_run.result + return None