Skip to content

Commit cdece74

Browse files
committed
Improve has_object_permission code
1 parent 225d3fe commit cdece74

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

api/features/permissions.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -63,16 +63,13 @@ def has_permission(self, request, view):
6363
def has_object_permission(self, request, view, obj):
6464
# map of actions and their required permission
6565
if view.action in ACTION_PERMISSIONS_MAP:
66-
tag_ids = []
66+
tag_ids = None
6767
required_permission = ACTION_PERMISSIONS_MAP.get(view.action)
6868
if required_permission in TAG_SUPPORTED_PROJECT_PERMISSIONS:
6969
tag_ids = list(obj.tags.values_list("id", flat=True))
70-
return request.user.has_project_permission(
71-
ACTION_PERMISSIONS_MAP[view.action], obj.project, tag_ids=tag_ids
72-
)
7370

7471
return request.user.has_project_permission(
75-
ACTION_PERMISSIONS_MAP[view.action], obj.project
72+
ACTION_PERMISSIONS_MAP[view.action], obj.project, tag_ids=tag_ids
7673
)
7774

7875
if view.action == "segments":

0 commit comments

Comments
 (0)