From c6879fb2345460e79bc52b910602c466c6496be3 Mon Sep 17 00:00:00 2001 From: Tushar <30565750+tushar5526@users.noreply.github.com> Date: Thu, 16 Nov 2023 12:12:32 +0530 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Matthew Elwell --- api/projects/permissions.py | 2 +- api/projects/tests/test_permissions.py | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/api/projects/permissions.py b/api/projects/permissions.py index 86aebaf6d175..265c7725c551 100644 --- a/api/projects/permissions.py +++ b/api/projects/permissions.py @@ -49,7 +49,7 @@ def has_permission(self, request, view): total_projects_created = Project.objects.filter( organisation=organisation ).count() - if total_projects_created >= subscription_metadata.projects: + if subscription_metadata.projects and total_projects_created >= subscription_metadata.projects: return False if organisation.restrict_project_create_to_admin: return request.user.is_organisation_admin(organisation.pk) diff --git a/api/projects/tests/test_permissions.py b/api/projects/tests/test_permissions.py index e2be3f08b7e2..48b8c5fc7b19 100644 --- a/api/projects/tests/test_permissions.py +++ b/api/projects/tests/test_permissions.py @@ -393,8 +393,7 @@ def test_free_plan_has_only_fixed_projects_permission(): mock_request.user = user for i in range(MAX_PROJECTS_IN_FREE_PLAN): - result = project_permissions.has_permission(mock_request, mock_view) + assert project_permissions.has_permission(mock_request, mock_view) Project.objects.create(name=f"Test project{i}", organisation=organisation) - assert result assert not project_permissions.has_permission(mock_request, mock_view)