From baf8ddb92b78241d3b0d41e421eeee662f6a6782 Mon Sep 17 00:00:00 2001 From: Matthew Elwell Date: Wed, 12 Jun 2024 16:07:35 +0100 Subject: [PATCH] fix: cascade delete versions when corresponding change request is deleted (#4152) --- ...03_cascade_delete_versions_on_cr_delete.py | 20 +++++++++++++++++++ api/features/versioning/models.py | 2 +- 2 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 api/features/versioning/migrations/0003_cascade_delete_versions_on_cr_delete.py diff --git a/api/features/versioning/migrations/0003_cascade_delete_versions_on_cr_delete.py b/api/features/versioning/migrations/0003_cascade_delete_versions_on_cr_delete.py new file mode 100644 index 000000000000..8e1c20fea346 --- /dev/null +++ b/api/features/versioning/migrations/0003_cascade_delete_versions_on_cr_delete.py @@ -0,0 +1,20 @@ +# Generated by Django 3.2.25 on 2024-06-12 14:43 + +from django.db import migrations, models +import django.db.models.deletion + + +class Migration(migrations.Migration): + + dependencies = [ + ('workflows_core', '0009_prevent_cascade_delete_from_user_delete'), + ('feature_versioning', '0002_add_api_key_for_creation_and_publish'), + ] + + operations = [ + migrations.AlterField( + model_name='environmentfeatureversion', + name='change_request', + field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='environment_feature_versions', to='workflows_core.changerequest'), + ), + ] diff --git a/api/features/versioning/models.py b/api/features/versioning/models.py index 0aeb842c5372..91234ce387e9 100644 --- a/api/features/versioning/models.py +++ b/api/features/versioning/models.py @@ -74,7 +74,7 @@ class EnvironmentFeatureVersion( change_request = models.ForeignKey( "workflows_core.ChangeRequest", related_name="environment_feature_versions", - on_delete=models.SET_NULL, + on_delete=models.CASCADE, null=True, blank=True, )