From b019a35df425e439c2ff36239bf6540c61ffe993 Mon Sep 17 00:00:00 2001 From: Matthew Elwell Date: Tue, 16 Apr 2024 13:30:04 +0100 Subject: [PATCH] fix: tests using `has_calls` instead of `assert_has_calls` (#3775) --- .../unit/features/test_unit_features_views.py | 2 +- api/tests/unit/sse/test_tasks.py | 37 ++++++++++--------- 2 files changed, 21 insertions(+), 18 deletions(-) diff --git a/api/tests/unit/features/test_unit_features_views.py b/api/tests/unit/features/test_unit_features_views.py index 5dfd2ac30388..fbdd1f1117c6 100644 --- a/api/tests/unit/features/test_unit_features_views.py +++ b/api/tests/unit/features/test_unit_features_views.py @@ -153,7 +153,7 @@ def test_feature_state_webhook_triggered_when_feature_deleted( mock_calls = [ mock.call(fs, WebhookEventType.FLAG_DELETED) for fs in feature_states ] - mocked_trigger_fs_change_webhook.has_calls(mock_calls) + mocked_trigger_fs_change_webhook.assert_has_calls(mock_calls) def test_remove_owners_only_remove_specified_owners(self): # Given diff --git a/api/tests/unit/sse/test_tasks.py b/api/tests/unit/sse/test_tasks.py index 6d9717fb1e2b..26c7614eb943 100644 --- a/api/tests/unit/sse/test_tasks.py +++ b/api/tests/unit/sse/test_tasks.py @@ -36,23 +36,26 @@ def test_send_environment_update_message_for_project_make_correct_request( send_environment_update_message_for_project(realtime_enabled_project.id) # Then - mocked_requests.post.has_calls( - mocker.call( - f"{base_url}/sse/environments/{realtime_enabled_project_environment_one.api_key}/queue-change", - headers={"Authorization": f"Token {token}"}, - json={ - "updated_at": realtime_enabled_project_environment_one.updated_at.isoformat() - }, - timeout=2, - ), - mocker.call( - f"{base_url}/sse/environments/{realtime_enabled_project_environment_two.api_key}/queue-change", - headers={"Authorization": f"Token {token}"}, - json={ - "updated_at": realtime_enabled_project_environment_two.updated_at.isoformat() - }, - timeout=2, - ), + mocked_requests.post.assert_has_calls( + calls=[ + mocker.call( + f"{base_url}/sse/environments/{realtime_enabled_project_environment_one.api_key}/queue-change", + headers={"Authorization": f"Token {token}"}, + json={ + "updated_at": realtime_enabled_project_environment_one.updated_at.isoformat() + }, + timeout=2, + ), + mocker.call( + f"{base_url}/sse/environments/{realtime_enabled_project_environment_two.api_key}/queue-change", + headers={"Authorization": f"Token {token}"}, + json={ + "updated_at": realtime_enabled_project_environment_two.updated_at.isoformat() + }, + timeout=2, + ), + ], + any_order=True, )