refac: make is_queue_full private

Author: gagantrivedi

api/task_processor/models.py

@@ -108,12 +108,11 @@ def create(
         args: typing.Tuple[typing.Any] = None,
         kwargs: typing.Dict[str, typing.Any] = None,
     ) -> "Task":
-        if queue_size:
-            if cls.is_queue_full(task_identifier, queue_size):
-                raise TaskQueueFullError(
-                    f"Queue for task {task_identifier} is full. "
-                    f"Max queue size is {queue_size}"
-                )
+        if queue_size and cls._is_queue_full(task_identifier, queue_size):
+            raise TaskQueueFullError(
+                f"Queue for task {task_identifier} is full. "
+                f"Max queue size is {queue_size}"
+            )
         return Task(
             task_identifier=task_identifier,
             scheduled_for=scheduled_for,
@@ -123,7 +122,7 @@ def create(
         )
 
     @classmethod
-    def is_queue_full(cls, task_identifier: str, queue_size: int) -> bool:
+    def _is_queue_full(cls, task_identifier: str, queue_size: int) -> bool:
         return (
             cls.objects.filter(
                 task_identifier=task_identifier,

api/tests/unit/task_processor/test_unit_task_processor_models.py

@@ -59,39 +59,3 @@ def test_recurring_task_run_should_execute_first_run_at(first_run_time, expected
         ).should_execute
         == expected
     )
-
-
-def test_is_queue_full_returns_true_if_queue_is_full(db):
-    # Given
-    task_identifier = "my_callable"
-
-    # some incomplete task
-    for _ in range(10):
-        Task.objects.create(task_identifier=task_identifier)
-
-    Task.create(task_identifier=task_identifier, scheduled_for=timezone.now())
-    # When
-    assert Task.is_queue_full(task_identifier, 9) is True
-
-
-def test_is_queue_full_returns_false_if_queue_is_not_full(db):
-    # Given
-    task_identifier = "my_callable"
-
-    # Some incomplete task
-    for _ in range(10):
-        Task.objects.create(task_identifier=task_identifier)
-
-        # tasks with different identifiers
-        Task.objects.create(task_identifier="task_with_different_identifier")
-
-        # failed tasks
-        Task.objects.create(
-            task_identifier="task_with_different_identifier", num_failures=3
-        )
-
-    # When
-    Task.create(task_identifier=task_identifier, scheduled_for=timezone.now())
-
-    # Then
-    assert Task.is_queue_full(task_identifier, 10) is False