Skip to content

Commit 457d458

Browse files
committed
refac(audit/task): early return if no related_object_id
1 parent f4e4105 commit 457d458

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

api/audit/tasks.py

+7-1
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,12 @@ def create_audit_log_from_historical_record(
8484

8585
environment, project = instance.get_environment_and_project()
8686

87+
related_object_id = instance.get_audit_log_related_object_id(history_instance)
88+
related_object_type = instance.get_audit_log_related_object_type(history_instance)
89+
90+
if not related_object_id:
91+
return
92+
8793
log_message = {
8894
"+": instance.get_create_log_message,
8995
"-": instance.get_delete_log_message,
@@ -93,7 +99,7 @@ def create_audit_log_from_historical_record(
9399
related_object_id = instance.get_audit_log_related_object_id(history_instance)
94100
related_object_type = instance.get_audit_log_related_object_type(history_instance)
95101

96-
if not (log_message and related_object_id):
102+
if not log_message:
97103
return
98104

99105
AuditLog.objects.create(

0 commit comments

Comments
 (0)