From 1065ad0258c36e76cca6a106d4888ffdc329d54e Mon Sep 17 00:00:00 2001 From: Matthew Elwell Date: Mon, 4 Dec 2023 17:22:16 +0000 Subject: [PATCH] fix: remove pagination from group summaries (#3090) --- .../unit/organisations/test_unit_organisations_views.py | 6 +++--- api/users/views.py | 5 +++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/api/tests/unit/organisations/test_unit_organisations_views.py b/api/tests/unit/organisations/test_unit_organisations_views.py index e21b71b5da61..efd98e115e95 100644 --- a/api/tests/unit/organisations/test_unit_organisations_views.py +++ b/api/tests/unit/organisations/test_unit_organisations_views.py @@ -1664,12 +1664,12 @@ def test_list_group_summaries( assert response.status_code == status.HTTP_200_OK response_json = response.json() - assert response_json["count"] == 2 - assert response_json["results"][0] == { + assert len(response_json) == 2 + assert response_json[0] == { "id": user_permission_group_1.id, "name": user_permission_group_1.name, } - assert response_json["results"][1] == { + assert response_json[1] == { "id": user_permission_group_2.id, "name": user_permission_group_2.name, } diff --git a/api/users/views.py b/api/users/views.py index d4c115084c13..5b57bbc684f6 100644 --- a/api/users/views.py +++ b/api/users/views.py @@ -191,6 +191,11 @@ def get_queryset(self): return qs + def paginate_queryset(self, queryset: QuerySet) -> list[UserPermissionGroup] | None: + if self.action == "summaries": + return None + return super().paginate_queryset(queryset) + def get_serializer_class(self): if self.action == "retrieve": return UserPermissionGroupSerializerDetail