Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clarifying unlicensed crates as deliberately unlicensed (previously possible in 0.2) #50

Closed
iliana opened this issue Dec 10, 2019 · 3 comments · Fixed by #103
Closed
Assignees
Labels
enhancement New feature or request

Comments

@iliana
Copy link

iliana commented Dec 10, 2019

Is your feature request related to a problem? Please describe.
I am working on a project where I've not identified the license I want to use yet, but I still want to use licenses.unlicensed = "deny" to deny unlicensed and unclarified dependencies. Listing a license in either Cargo.toml or deny.toml would be inaccurate if I'm planning on keeping the project history.

Describe the solution you'd like
Maybe Clarification could have unlicensed: Option<true> or the like.

[[licenses.clarify]]
name = "my-neat-project"
unlicensed = true

Describe alternatives you've considered
We're currently locking to cargo-deny 0.2 to keep this functionality as part of the skip key.

@Jake-Shadle
Copy link
Member

I could see adding this feature, or maybe even a specific setting for ignoring the root level crate(s).

@iliana
Copy link
Author

iliana commented Dec 10, 2019

I’d definitely prefer the top-level “unlicensed top level crates” lint argument, that’s a good approach — happy to implement if there's an agreed-upon config key :)

@Jake-Shadle
Copy link
Member

@iliana Oh no, I didn't see offer to implement this! I was thinking of something like ignore-workspace or the like which is just a boolean that defaults to false. If it's true the license check would then just skip any package in this list https://docs.rs/cargo_metadata/0.9.1/cargo_metadata/struct.Metadata.html#structfield.workspace_members (but would probably still emit a Severity::Help that was skipped).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants